SIGWINCH #7
Closed
SIGWINCH #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -40,7 +41,7 @@ type streamProtocolV1 struct { | |||
|
|
|||
| var _ streamProtocolHandler = &streamProtocolV1{} | |||
|
|
|||
| func (e *streamProtocolV1) stream(conn httpstream.Connection) error { | |||
| func (e *streamProtocolV1) stream(conn httpstream.Connection, _ <-chan term.Size) error { | |||
There was a problem hiding this comment.
would hide this behind an interface - raw channels may not always solve the problem.
There was a problem hiding this comment.
@smarterclayton something like this?
type ResizeEventQueue interface {
// Pop is a blocking call that waits for the next terminal resize event
// and then returns the current terminal size.
// If the queue has shut down, nil will be returned.
Pop() *term.Size
}
ncdc
force-pushed
the
exec-sigwinch
branch
2 times, most recently
from
091d53c
to
2d83975
Compare
ncdc
pushed a commit
that referenced
this pull request
May 16, 2016
Fixed the order of fields for basic_auth. This provider still needs to leverage common.sh for generating proper credentials though. Also documented a pattern for how to get the SWIFT_SERVER_URL automatically
ncdc
force-pushed
the
exec-sigwinch
branch
4 times, most recently
from
9681600
to
5b050d0
Compare
ncdc
force-pushed
the
exec-sigwinch
branch
2 times, most recently
from
2bceb00
to
c412724
Compare
Revert gs://kubernetes-release-dev changes
…rr-non-existing-ctr Automatic merge from submit-queue kubectl attach: error out for non-existing containers Currently, kubectl attach falls back to the first container which is pretty confusing. Based on kubernetes#27541.
Automatic merge from submit-queue Fixed misleading error message when a resource with no selector or na… Commit: - Fixed misleading error message when a resource with no selector or name is provided to kubectl delete or label command This commit fixes kubernetes#25541
…-federation-e2e Automatic merge from submit-queue Fix federation e2e tests by correctly managing cluster clients 1. The main fix: Correct overall BeforeEach() to create a new set of cluster clients, rather than just append to the set created by all previous tests. This was screwing up a lot of stuff in difficult to diagnose ways. 2. Add lots of debug logging. 3. Be better about cleaning up after each test. ``` SUCCESS! -- 6 Passed | 0 Failed :-) ``` cc @nikhiljindal @madhusudancs @mfanjie @colhom FYI
…l_drain Automatic merge from submit-queue Add link to diagram of `kubectl drain`
…h-alt-ci"" This reverts commit fe64293.
Automatic merge from submit-queue scheduler: change phantom pod test from integration into unit test This is an effort for kubernetes#24440. Why this PR? - Integration test is hard to debug. We could model the test as a unit test similar to [TestSchedulerForgetAssumedPodAfterDelete()](https://github.com/kubernetes/kubernetes/blob/132ebb091af3b625df0ad19a5975119e800bebef/plugin/pkg/scheduler/scheduler_test.go#L173). Currently the test is testing expiring case, we can change that to delete. - Add a test similar to TestSchedulerForgetAssumedPodAfterDelete() to test phantom pod. - refactor scheduler tests to share the code between TestSchedulerNoPhantomPodAfterExpire() and TestSchedulerNoPhantomPodAfterDelete() - Decouple scheduler tests from scheduler events: not to use events
This is required to run kubelet with kubenet.
This is required to run kubelet with kubenet.
…nx-image Automatic merge from submit-queue Remove duplicated nginx image. Use nginx-slim instead This PR removes the image `gcr.io/google_containers/nginx:1.7.9` and uses `gcr.io/google_containers/nginx-slim:0.7`. Besides removing the duplication `1.7.9` is 16 months old.
Automatic merge from submit-queue Document known issues for v1.3.0
Automatic merge from submit-queue E2E: Add UpdatePod function in e2e framework and change the test to use it. Fix kubernetes#28096. Some e2e tests need to update pod, but the pod update is a bit complex because of potential conflict. kubernetes#28096 happened just because the test only called pod `Update` once. This PR move the update pod logic into a util function `UpdatePod` in e2e framework, and change the tests to use it. Mark P2 because the original issue is P0, but in fact happens not quite frequently. :) []() the test to use it.
…e-check-dep Automatic merge from submit-queue Revert "Declare out of disk when there is no free inodes" Reverts kubernetes#28176 Fixes kubernetes#28481
…donly-var Automatic merge from submit-queue Copy FEDERATIONS_DOMAIN_MAP to a local variable since the helper script doesn't allow overwriting the existing variable. cc @kubernetes/sig-cluster-federation []()
Automatic merge from submit-queue Add spec.Name() to the configmap GetVolumeName() This is to base the name on the volume not just on the source configMap. If you have 2 volumes that both have the same configMap as a source, the volume is see as being in the attached state (it's state is looked up based on GetVolumeName()). Fixes kubernetes#28502
Automatic merge from submit-queue getting emailAddress from TLS cert Kubernetes if using TLS cert to perform authentication will use the CommonName field of the cert as the authenticating user. In https://github.com/kubernetes/kubernetes/blob/master/plugin/pkg/auth/authenticator/request/x509/x509.go#L106, alternative methods are defined to use emailAddress or DNSName as the authenticating user. The method that uses the emailAddress is not comprehensive as this information can be encoded in different places of the certificate. This PR fixes this.
Automatic merge from submit-queue kubectl should print usage at the bottom Override the Usage: output using SetUsageTemplate. Just moved the strings in the template to make sure we print Usage: at the bottom of the output and not at the top. Fixes issue kubernetes#7496
…entset Automatic merge from submit-queue [client-gen] stop update release_1_3 clientset; create release_1_4 We'll bump the version after we cut 1.3 release. I'll keep this PR assigned to myself in the mean time. @lavalamp
Automatic merge from submit-queue Collect cluster state into a single type. Mostly just makes it easier to read and, hopefully, extend.
Automatic merge from submit-queue daemon/controller.go: remove unused func enqueueAllDaemonSets
Automatic merge from submit-queue fix some typos Just a minor typos fix. Signed-off-by: bin liu <liubin0329@gmail.com>
…noise Automatic merge from submit-queue kubectl convert --local prints info message to stderr fix kubernetes#28298
Automatic merge from submit-queue delete the redundant word "a" In file docs/reporting-security-issues.md, line kubernetes#37, "If you believe you have discovered a vulnerability or a have a security incident to report", here the second "a" is redundant, should be deleted.
…reated Automatic merge from submit-queue "was not created" should be "was created" In file pkg\client\restclient/request_test.go, line kubernetes#1089, "t.Errorf("expected object was not created")" , here "was not created" should be "was created" because the if condition is "if wasCreated".
Automatic merge from submit-queue Reformat kubectl completion example text
Automatic merge from submit-queue Make kubectl help strings consistent
Automatic merge from submit-queue Log all image deletion errors instead of just the last one kubernetes#27169
Automatic merge from submit-queue Change redis image gcr Follow up kubernetes#27577 (comment): > Any chance we can move these images somewhere in gcr.io? I pushed `kubernetes/redis:v1` to `gcr.io/google_containers/redis:v1`. []()
…iles Automatic merge from submit-queue Cleanup hack/ Dockerfiles <!-- Checklist for submitting a Pull Request Please remove this comment block before submitting. 1. Please read our [contributor guidelines](https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md). 2. See our [developer guide](https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md). 3. If you want this PR to automatically close an issue when it is merged, add `fixes #<issue number>` or `fixes #<issue number>, fixes #<issue number>` to close multiple issues (see: https://github.com/blog/1506-closing-issues-via-pull-requests). 4. Follow the instructions for [labeling and writing a release note for this PR](https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes) in the block below. --> ```release-note Small improvements to hack/ Dockerfiles ``` []()
Automatic merge from submit-queue
build: fixed ${KUBE_ROOT} prefix for build scripts
Running `./make-build-image.sh` command inside the `build` directory doesn't work:
```sh
$ cd build
$ ./make-build-image.sh
./../build/common.sh: line 32: hack/lib/init.sh: No such file or directory
```
This PR adds `${KUBE_ROOT}` prefix for the `source` bash function. Also I added braces to unify the code style.
[]()
…over-log Automatic merge from submit-queue Log available pods of deployments when scaling down old RS Ref kubernetes#26834 []()
…-update Automatic merge from submit-queue api: validate generation updates @bprashanth @liggitt PTAL
ncdc
force-pushed
the
exec-sigwinch
branch
2 times, most recently
from
82bfa32
to
583b838
Compare
Add support for terminal resizing for exec, attach, and run. Note that for Docker, exec sessions inherit the environment from the primary process, so if the container was created with tty=false, that means the exec session's TERM variable will default to "dumb". Users can override this by setting TERM=xterm (or whatever is appropriate) to get the correct "smart" terminal behavior.
ncdc
pushed a commit
that referenced
this pull request
Aug 17, 2016
- Cannot attach scsi devices to slot #7 - Limit of 4 scsi controllers per vm MAX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: