Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JOSS] Instructions for downloading example data #575

Closed
calebweinreb opened this issue Jun 28, 2024 · 1 comment · Fixed by #579
Closed

[JOSS] Instructions for downloading example data #575

calebweinreb opened this issue Jun 28, 2024 · 1 comment · Fixed by #579

Comments

@calebweinreb
Copy link

Re JOSS review openjournals/joss-reviews#6889

Currently the tutorial notebook Additive_and_multiplicative_bias includes the following note:

Note: In this tutorial we use the forecast and analysis grids that are downloaded or derived in First_Data_Fetching.ipynb. Please run through this tutorial first to fetch data.

This is very helpful and should ideally be added to other notebooks that use the same datasets, since users may not go through these notebooks in chronological order. For example the MSE, MAE, and RMSE notebooks all rely on forecast_grid.nc and analysis_grid.nc but don't explain where they come from.

@tennlee
Copy link
Collaborator

tennlee commented Jun 30, 2024

Thanks for that feedback. I have addressed it in PR #579 . Feel free to re-open this issue if you have any further feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants