-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add static code analysis to GitHub Actions #73
Comments
Looks like a great start, but where does the coverage report end up? I couldn't work out how to actually put the output report somewhere in a nicely viewable way. It's worthwhile regardless, but it would be ncie to have easily viewable results |
These changes just get the coverage working. Currently pytest raises this warning If we want to adopt a third party tool to make it a bit more visible, there's several options, eg:
Happy to work on adding one of these too, if we can decide what we want. |
That makes sense. I'm aware of the third-party approached to coverage reporting. They provide some nice additional features, but it's also an additional technology to maintain. I'm open to it, but let's have that discussion about what we want after closing out the current issue? |
@John-Sharples I fixed the no coverage collected issue in #87. It had to do with requiring an editable install as As for badges, I had a look at how to implement badges in actions and it is such a stuff around compared to gitlab that I don't even want to try 😄. As for this I think we could close this issue since pre-commit and tests have been implemented in the |
Is your feature request related to a problem? Please describe.
To ensure consistent style and code quality we need to add some static code checks. Requested feature is to add new github action to run static code analysis, including
black
,pylint
,isort
, andmypy
.Describe the solution you'd like
New GitHub actions to run above mentioned tools automatically on
push
andpull-request
.Happy to be assigned to this task
The text was updated successfully, but these errors were encountered: