Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve round_values docstring #96

Closed
nicholasloveday opened this issue Nov 3, 2023 · 0 comments · Fixed by #102
Closed

Improve round_values docstring #96

nicholasloveday opened this issue Nov 3, 2023 · 0 comments · Fixed by #102

Comments

@nicholasloveday
Copy link
Collaborator

The docstring in https://github.com/nci/scores/blob/develop/src/scores/probability/functions.py#L19 needs to be clearer to ensure that the user understands that the rounding_precision arg is different to specifying how many places one wants to round to.
@nicholasloveday nicholasloveday linked a pull request Nov 10, 2023 that will close this issue
updated round_values docstring #102
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

updated round_values docstring nci/scores
1 participant
@nicholasloveday