Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selecting the scope for the client in DI #449

Closed
smolchanovsky opened this issue Jul 19, 2022 · 3 comments · Fixed by #460
Closed

Selecting the scope for the client in DI #449

smolchanovsky opened this issue Jul 19, 2022 · 3 comments · Fixed by #460
Assignees
@Kingmidas74
Labels
Cost: M Needs: Design Priority: Medium Type: Enhancement New feature or request
Milestone
0.14.0

Comments

@smolchanovsky
Copy link
Member

Now clients are created as singletons. This does not allow using non-singleton instance classes to create it.
@smolchanovsky smolchanovsky added this to the 0.15.0 milestone Jul 23, 2022
@Kingmidas74
Copy link
Member

Do you want additional method like AddRestNClientTransient, AddRestNClientSingleton, etc.. or additional option for current methods?

@smolchanovsky smolchanovsky mentioned this issue Sep 3, 2022
Closed
@smolchanovsky
Copy link
Member Author

Ideally, we need both, but perhaps there are enough AddRestNClientTransient, AddRestNClientSingleton and AddRestNClientScoped methods for the first time.

@Kingmidas74 Kingmidas74 self-assigned this Sep 11, 2022
@Kingmidas74 Kingmidas74 linked a pull request Sep 11, 2022 that will close this issue
Selecting the scope for the client in DI #460
Merged
@Kingmidas74
Copy link
Member

Well... I've done both.

@Kingmidas74 Kingmidas74 modified the milestones: 0.15.0, 0.14.0 Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kingmidas74 Kingmidas74

Labels
Cost: M Needs: Design Priority: Medium Type: Enhancement New feature or request
Milestone
0.14.0
Development

Successfully merging a pull request may close this issue.

Selecting the scope for the client in DI nclient/NClient
2 participants
@Kingmidas74 @smolchanovsky