Remove raster, rgdal, sp packages from dependencies #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
petrasovaa
commented
Nov 28, 2023
•
petrasovaa
commented
- removes packages rgdal, raster, sp
- replaced one line that was using raster to use terra instead, please check, I don't know if tests cover this
- landscapemetrics changed to 2.0.0
- added macOS dependency, CI was failing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #187 +/- ##
==========================================
- Coverage 84.87% 84.59% -0.28%
==========================================
Files 51 51
Lines 5647 5649 +2
==========================================
- Hits 4793 4779 -14
- Misses 854 870 +16 ☔ View full report in Codecov by Sentry. |
ChrisJones687
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
add terra:: before which.min
There was a problem hiding this comment.
Are you sure? It looks like it's running on a list of numbers or something like it, not a raster. There is no terra in front of the other two which.min.
|
Any idea why testthat runs forever sometimes in CI? |
|
Not sure it occasionally gets hung up at loading packages and sometimes on
testthat. It doesn't get stuck locally on either my Mac or Windows machine
so I can't see why it would elsewhere.
…On Wed, Nov 29, 2023 at 9:37 AM Anna Petrasova ***@***.***> wrote:
Any idea why testthat runs forever sometimes in CI?
—
Reply to this email directly, view it on GitHub
<#187 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE3WLXROISZLIOWUIDKG7KLYG5CA7AVCNFSM6AAAAAA7566ET6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZSGAYTOOBTGY>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.