Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install script fails on Synology systems due to lack of unzip command #1949

Closed
Webreaper opened this issue Dec 29, 2017 · 4 comments
Closed
Milestone

Comments

@Webreaper
Copy link
Contributor

The new install script for rclone fails on a Synology OS because Synology doesn't have the unzip command by default. Instead, Synology provides the 7z command.

So if we replace the existing unzip command:

unzip -a $rclone_zip -d $unzip_dir
with this:

if hash unzip 2>/dev/null; then
	unzip -a $rclone_zip -d $unzip_dir 
else
	7z x $rclone_zip -o$unzip_dir
fi

the script will work on Synology.

@ncw
Copy link
Member

ncw commented Jan 5, 2018

@qaskai what do you think about making the script look for 7z if unzip isn't available?

it would be quite nice if the script errored at the start if neither is available as unzip isn't a standard install for eg, debian.

@ncw ncw added the enhancement label Jan 5, 2018
@ncw ncw added this to the v1.40 milestone Jan 5, 2018
@qaskai
Copy link
Contributor

qaskai commented Jan 5, 2018

Yeah, that’s a good idea. Now I wonder how I could fail to consider this problem while making the script! I’ll make a PR ASAP.

Also apologies to @Webreaper for the slow response.

@Webreaper
Copy link
Contributor Author

Don't fret, it's really no biggie. Having a script at all is great! Thanks!

@ncw
Copy link
Member

ncw commented Jan 10, 2018

I've pushed up a new script to rclone.org which should work for you now - thanks to @qaskai for the changed :-)

@ncw ncw modified the milestones: v1.40, v1.41 Mar 19, 2018
@ncw ncw modified the milestones: v1.41, v1.42 Apr 28, 2018
@ncw ncw modified the milestones: v1.42, v1.43 Jun 17, 2018
@ncw ncw closed this as completed Sep 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants