Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged master and manage-users—implements unpolished co-editor feature #127

Merged
merged 26 commits into from
May 3, 2014

Conversation

ndarville
Copy link
Owner

  • Push CSS diff to sass branch
  • Fix Travis-only problem

@ndarville
Copy link
Owner Author

elementtree package breaks. Need to change my requirements.txt to just include the package with no versioning.

Thing is, the package was updated on manage-users, but the change hasn’t made it to requirements.txt, looks like.

@ndarville
Copy link
Owner Author

So, using both the general and specific versioning of elementtree didn’t take.

@ndarville
Copy link
Owner Author

Using pip --pre -r requirements.txt had the same result. Last idea: --allow-external.

@ndarville
Copy link
Owner Author

And this is why you don’t push a PR fix right after a nap.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 8e82d53 on manage-users into * on master*.

@ndarville
Copy link
Owner Author

Managed to reproduce Travis errors locally.

@ndarville
Copy link
Owner Author

Looks like the created server itself works perfectly; perhaps the test itself is broken.

Could be bleach:

>>> from forum.views import sanitized_smartdown as sd
>>> sd("foo")
No handlers could be found for logger "bleach"
======================================================================
FAIL: Tests the HTML input of an abbr element.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/darville/Dropbox/projects/django/pony-forum/pony-forum/forum/input_tests.py", line 94, in test_html
    self.assertEquals(sd(self.output), self.output)
AssertionError: u'' != '<p><abbr>foo</abbr></p>'
-------------------- >> begin captured logging << --------------------
bleach: ERROR: HTML: TypeError("'NoneType' object is not callable",)
Traceback (most recent call last):
  File "~/pony-forum/venv/lib/python2.7/site-packages/bleach/__init__.py", line 326, in _render
    return force_unicode(_serialize(tree))
  File "~/pony-forum/venv/lib/python2.7/site-packages/bleach/__init__.py", line 338, in _serialize
    stream = walker(domtree)
TypeError: 'NoneType' object is not callable
bleach: ERROR: XML: AttributeError('toxml',)
Traceback (most recent call last):
  File "~/pony-forum/venv/lib/python2.7/site-packages/bleach/__init__.py", line 330, in _render
    return force_unicode(tree.toxml())
AttributeError: toxml
--------------------- >> end captured logging << ---------------------
>>> from forum.views import sanitized_smartdown as sd
>>> sd("foo")
No handlers could be found for logger "bleach"
u''

>>> import bleach
>>> bleach.clean("FOO")
u''
>>> bleach.clean("<a>FOO</a>")
u''
>>> 

@ndarville
Copy link
Owner Author

Updating bleach to 1.2.2 fixed it.

@ndarville
Copy link
Owner Author

Now to pull SCSS and merge.

@ndarville
Copy link
Owner Author

Looks like I had already pushed the CSS diff: c3bf4b9.

ndarville added a commit that referenced this pull request May 3, 2014
Merged manage-users branch; implements unpolished co-editor feature
@ndarville ndarville merged commit e8bed6e into master May 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants