Weeder does not detect redundant build dependecies in common stanzas

[recursion-ninja]

If we have a common stanza in our cabal file that includes a build-depends component with one or more dependencies, and each of the build targets that imports that common stanza does not require one or more of the dependencies listed in the build-depends of the common stanza, then weeder does not report these as redundant dependencies.

Consider the following .cabal file:

name: my-package

common deps

  build-depends: libA, libB

library

  import deps

  [... more stuff here ...]

executable exe

  import deps

  [... more stuff here ...]

If neither the executable exe nor the package library my-package require libA or libB, it would be very helpful for weeder to report libA and libB are redundant dependencies.

This issue is perhaps speculative, as I don't know if it is feasible for weeder to do this.

[ndmitchell]

Weeder predates the common syntax. Certainly easy enough to add - just a patch to https://github.com/ndmitchell/weeder/blob/master/src/Cabal.hs. PR welcome!

I would actually say that anything imported from a common stanza but not used should be considered a weed. Every unused package increases compile time etc, so only shared things should actually be put in common sections.

[ndmitchell]

Weeder 2.0 is being developed at https://github.com/ocharles/weeder so I suggest you go see if that fixes your issues.