Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features and references with missing ID parts are detected and reported #18

Closed
l-laura opened this issue Jul 19, 2023 · 0 comments · Fixed by #33
Closed

Features and references with missing ID parts are detected and reported #18

l-laura opened this issue Jul 19, 2023 · 0 comments · Fixed by #33
Assignees
Milestone

Comments

@l-laura
Copy link
Contributor

l-laura commented Jul 19, 2023

The mapget model implementation currently creates features from a tile without validating if the feature ID fields are set. This will lead to problems with implementing e.g. jump-to-feature down the line, where a feature reference must contain all the information to be resolved to a feature.

To fix the issue, the mapget model should check that the ID fields are set, before adding a feature or feature reference to the feature layer.

@josephbirkner josephbirkner added this to the 0.2.0 milestone Jul 20, 2023
@l-laura l-laura self-assigned this Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants