Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting a comment produces error and CSS updated incorrectly #43

Closed
levelonedev opened this issue Feb 19, 2015 · 4 comments
Closed

Deleting a comment produces error and CSS updated incorrectly #43

levelonedev opened this issue Feb 19, 2015 · 4 comments

Comments

@levelonedev
Copy link
Collaborator

Before Delete

After Delete

Upon refreshing the page you find that the comment is no longer there.
@neagle
Copy link
Owner

neagle commented Feb 19, 2015

Hm! Is this on live? I just tried deleting comments both as my main account and with a test account and didn't have any problems.

@levelonedev
Copy link
Collaborator Author

Yeah! I did more debugging and it appears in chrome under windows as well.
chrome_windows_7

@neagle
Copy link
Owner

neagle commented Feb 20, 2015

Thanks for working this out with me over IM! The problem was that kifu uploaded before this commit, didn't have original games saved. I thought I took care of this by adding a check when kifu were saved or updated, but I forgot that when comments are added to kifu, they have to push a reference to the kifu and save it, too.

Great, great, great job finding this and bringing it to my attention. Thanks!

@neagle neagle closed this as completed Feb 20, 2015
@neagle
Copy link
Owner

neagle commented Feb 20, 2015

Fixed by 741dbd6

@levelonedev levelonedev mentioned this issue Feb 20, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@neagle @levelonedev