Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't rely on the socket ID; use the username instead #15

Closed
nealwu opened this issue May 24, 2016 · 1 comment
Closed

Don't rely on the socket ID; use the username instead #15

nealwu opened this issue May 24, 2016 · 1 comment
Assignees
@nealwu

Comments

@nealwu
Copy link
Owner

nealwu commented May 24, 2016 •
edited
Loading

The socket ID isn't consistent; for example when the servers crashes and restarts, the socket ID changes client-side even though the user is able to reconnect.

The main place where this is used is io.js (specifically gameSeatToSocket), but there may be other places as well.
@nealwu nealwu self-assigned this May 24, 2016
@nealwu
Copy link
Owner Author

nealwu commented May 25, 2016

Fixed by dbed1e5

@nealwu nealwu closed this as completed May 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nealwu nealwu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nealwu