Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schema): for chars #292

Closed
dzmitry-lahoda opened this issue May 1, 2024 · 4 comments
Closed

feat(schema): for chars #292

dzmitry-lahoda opened this issue May 1, 2024 · 4 comments

Comments

@dzmitry-lahoda
Copy link
Contributor

No description provided.

@dj8yfo
Copy link
Collaborator

dj8yfo commented May 3, 2024

@dzmitry-lahoda this has been proposed earlier https://github.com/near/borsh-rs/pull/248/files .
Does it look like what is required of this issue resolution?

@dzmitry-lahoda
Copy link
Contributor Author

Indded, sorry. Was too Rust centric.

@dzmitry-lahoda
Copy link
Contributor Author

dzmitry-lahoda commented May 3, 2024

@dj8yfo btw schema for chars, not serde for chars.

#247 (comment)

i more of need metadata for chars, okey to have variable lengths.

i build something like reflection/diff of data storage of borsh.

@dj8yfo
Copy link
Collaborator

dj8yfo commented May 3, 2024

Indded, sorry. Was too Rust centric.

well, rust stdlib has an explanation that char is Unicode Scalar Value, serializing it as 21 bits or 4 bytes would be an implementation detail; 4 bytes would be a lot simpler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants