-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ShardUId #4659
Merged
Merged
Implement ShardUId #4659
Changes from 13 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
b0d9267
Implement ShardUId
66ec5b8
update ColTrieChanges to always use ShardUId
30c2536
change Test::genesis_sharded to use shard_version 1, see what tests w…
8a71e12
Merge branch 'master' into shardid-new
mzhangmzz 12787f0
remove test_sharded_with_version since it's the same as test_sharded now
b1009c4
Merge branch 'master' into shardid-new
bowenwang1996 d3a4e8b
Merge branch 'master' into shardid-new
mzhangmzz 92796f4
address comments
64c4e5b
Merge branch 'master' into shardid-new
mzhangmzz 13cd213
make ShardLayoutV0 and ShardLayoutV1 public
780b838
Merge branch 'master' into shardid-new
mzhangmzz 07a6ce5
check ShardLayout and num_block_producer_seats_per_shard.len() have t…
81e3b7d
Merge branch 'master' into shardid-new
mzhangmzz f3b3901
link issue
2d87a25
fix state sync to use the correct block hash
4e5c7f7
Merge branch 'master' into shardid-new
1db0073
fix merge
2bb24a2
fix neard testnet to use shard_version = 0 instead of 1
c29f7a4
Merge branch 'master' into shardid-new
mzhangmzz da1188e
fix test_rejoin
c5f99ba
fix error propagation. Now the functions this PR touched propagates e…
58507cb
Merge branch 'master' into shardid-new
mzhangmzz 50a4f2c
Merge branch 'master' into shardid-new
mzhangmzz 7a0bb0c
Merge branch 'master' into shardid-new
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am afraid that
sync_hash
is not what you want here becausesync_hash
is the first block of the new block and I believe here the chunk could be included in a block in the previous epochThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, but we will disable state sync for epoch changes where resharding happens. I will add a comment here noting that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created an issue #4711 noting this