fix: set access key nonce on implicit account creation #5482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Longarithm
requested review from
bowenwang1996,
EgorKulikov,
matklad,
mm-near and
mzhangmzz
as code owners
Longarithm
added
the
A-transaction-runtime
matklad
approved these changes
Nov 26, 2021
added 2 commits
November 27, 2021 02:15
added 3 commits
November 27, 2021 03:52
mm-near
approved these changes
Nov 29, 2021
near-bulldozer bot
pushed a commit
that referenced
this pull request
Dec 14, 2021
Stabilize #5482. Also, update changelog for 1.23.0 release. ## Reasoning Previously, we changed formulas for tx nonce computation to avoid tx hash collisions: #3779 Later we figured out that it was not enabled for implicit accounts - on its creation, we simply created new access key with nonce 0. So we need this to make formula consistent among all accounts, and to get rid of tx hash collisions completely. The fix itself is straightforward. ## Testing Existing tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix access key nonce for implicit accounts to fully address the issue #3779.
The change is straightforward - formula for nonce should be the same as for explicit accounts, as here -
nearcore/runtime/runtime/src/actions.rs
Lines 561 to 562 in 7f7347f
Test plan
test_transaction_hash_collision_for_implicit_account_[ok|fail]- check that tx is applied or rejected depending on the protocol version.