feat: stabilize nonce range for implicit accounts #5802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Longarithm
requested review from
bowenwang1996,
EgorKulikov,
matklad,
mm-near and
mzhangmzz
as code owners
bowenwang1996
approved these changes
Dec 14, 2021
matklad
approved these changes
Dec 14, 2021
EgorKulikov
approved these changes
Dec 14, 2021
Comment on lines
+18
to
+21
| ### Non-protocol Changes | ||
|
|
||
| * Increase RocksDB cache size to 512 MB for state column to speed up blocks processing [#5212](https://github.com/near/nearcore/pull/5212) | ||
|
|
There was a problem hiding this comment.
Is this somehow related to this feature?
There was a problem hiding this comment.
No. This is not the first time I try to push multiple changes in one PR -_-
Let me leave it for this PR, but I write this comment as note for myself to separate such changes in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stabilize #5482. Also, update changelog for 1.23.0 release.
Reasoning
Previously, we changed formulas for tx nonce computation to avoid tx hash collisions: #3779
Later we figured out that it was not enabled for implicit accounts - on its creation, we simply created new access key with nonce 0.
So we need this to make formula consistent among all accounts, and to get rid of tx hash collisions completely. The fix itself is straightforward.
Testing
Existing tests.