Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write integration tests #12

Closed
4 tasks done
martinm-nm opened this issue Aug 10, 2021 · 0 comments · Fixed by #14
Closed
4 tasks done

Write integration tests #12

martinm-nm opened this issue Aug 10, 2021 · 0 comments · Fixed by #14
Assignees
Labels
enhancement New feature or request

Comments

@martinm-nm
Copy link
Contributor

martinm-nm commented Aug 10, 2021

libddog is a library that generates code meant for Datadog. In order to have confidence that our code is valid it would help enormously to have a set of integration tests that can serve as regression tests against future changes in Datadog and consequent incompatibilities in libddog.

Running the integration tests will require api keys, so they cannot be set up to run automatically in CI. They will need to be run manually.

  • A dashboard that exemplifies use of all (or most of?) the widgets that libddog currently supports.
  • A dashboard that uses all (or a sensible selection of?) the metrics query language, including functions.
  • A test that puts these dashboards (make sure it's using dashboard id/titles in such a way that it's clear it's purely used for QA purposes) on Datadog and validates that the update was successful.
  • An extension to the test that gets the dashboard after updating it and compares it to the definitions we have locally.
@martinm-nm martinm-nm added the enhancement New feature or request label Aug 10, 2021
@martinm-nm martinm-nm self-assigned this Aug 10, 2021
@martinm-nm martinm-nm mentioned this issue Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant