Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block syncing / announcement for AlphaNet #640

Merged
merged 6 commits into from Mar 2, 2019

Conversation

Projects
None yet
3 participants
@ilblackdragon
Copy link
Member

ilblackdragon commented Mar 1, 2019

Adding channeling for block importing / block announcement.
Integration test to excerising importing/announcment

Adding channeling for block importing / block announcement. Integrati…
…on test to excerising importing/announcment

@ilblackdragon ilblackdragon requested a review from mfornet Mar 1, 2019

mfornet and others added some commits Mar 1, 2019

_ => panic!("Should produce block"),
};
let (beacon_block, shard_block) =
match alice.client.try_produce_block(1, ChainPayload::default()) {

This comment has been minimized.

@mfornet

mfornet Mar 2, 2019

Collaborator

To producing a block we also need to add evidence that consensus was achieved in this block (and in the state). But we will add the evidence after consensus is really achieved so that blocks are only accepted if they have correct proofs (Consensus on the proposal and on the new state).

@mfornet

mfornet approved these changes Mar 2, 2019

@mfornet mfornet merged commit 707f332 into master Mar 2, 2019

1 check was pending

ci/gitlab/block_importing Pipeline running on GitLab
Details
@nearmax

This comment has been minimized.

Copy link
Collaborator

nearmax commented Mar 9, 2019

We need a separate PR to finalize block syncing as a feature. Right now block syncing happens optimistically -- we just hope that announcements are enough, which they are not. E.g. if some peer falls behind too much it will not be able to catch-up because we do not have pro-active/reactive block fetching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.