Block syncing / announcement for AlphaNet #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on test to excerising importing/announcment
mfornet
reviewed
Mar 2, 2019
| _ => panic!("Should produce block"), | ||
| }; | ||
| let (beacon_block, shard_block) = | ||
| match alice.client.try_produce_block(1, ChainPayload::default()) { |
There was a problem hiding this comment.
To producing a block we also need to add evidence that consensus was achieved in this block (and in the state). But we will add the evidence after consensus is really achieved so that blocks are only accepted if they have correct proofs (Consensus on the proposal and on the new state).
mfornet
approved these changes
Mar 2, 2019
|
We need a separate PR to finalize block syncing as a feature. Right now block syncing happens optimistically -- we just hope that announcements are enough, which they are not. E.g. if some peer falls behind too much it will not be able to catch-up because we do not have pro-active/reactive block fetching. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding channeling for block importing / block announcement.
Integration test to excerising importing/announcment