Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more than one owner/account per omg.lol address #99

Open
lxjv opened this issue Oct 25, 2021 · 8 comments
Open

Allow more than one owner/account per omg.lol address #99

lxjv opened this issue Oct 25, 2021 · 8 comments
Assignees
Labels
core Related to the core omg.lol service enhancement New feature or request

Comments

@lxjv
Copy link
Collaborator

lxjv commented Oct 25, 2021

so i have an O.L address (sin.omg.lol) for a thing that me and a friend are creating and i dont want to be the only one that can change stuff

(ahem paging @PlagueMan)

@ThijsNameIsTaken
Copy link
Contributor

This is basically why I created #34 (tbh also seems like an easier managable option, just create a second account and put the domain on it.)

@lxjv
Copy link
Collaborator Author

lxjv commented Oct 26, 2021

yeah i just think its kind of counter productive to have to log out of my account, find the login for that account, login to it, change stuff then repeat with my account

@chxseh
Copy link
Contributor

chxseh commented Oct 26, 2021

Transferring ownership and having two accounts that have access to one address is not the same thing and should be treated as such.

@newbold newbold self-assigned this Oct 27, 2021
@newbold newbold added enhancement New feature or request core Related to the core omg.lol service labels Oct 27, 2021
@newbold
Copy link
Member

newbold commented Oct 27, 2021

This is a great idea. Here's what I'm thinking:

  1. Each address has a single canonical owner — which would be the person who bought it, by default (and the person 'responsible' for the address in the context of adhering to the TOS)
  2. The address owner can invite other people to co-manage the address. They'd invite via email address, which would send a link. Invitee clicks the link to accept, which creates an account for them and they'll see the address listed as if it was their own (but it will be clear that they're a "co-manager", not an "owner".
  3. Co-managers would be able to manage all aspects of the address except for adding additional co-managers or transferring address ownership (which is going to be a separate thing @ThijsNameIsTaken so Allow transfers of address ownership #34 is still going to be done). While a more granular permission level (e.g. "they can update the profile but not change DNS) would be nice, in the interest of getting the feature out the door I'd like to keep it simple. People who use the feature will just need to trust the people that they invite to co-manage an address.

Am I leaving anything out there? I think this should cover a minimum viable implementation of the feature (and meet @lakerjv's use case) but let me know anyone can think of other stuff to consider here. Looking forward to getting started on this soon!

@chxseh
Copy link
Contributor

chxseh commented Oct 27, 2021

Sounds like exactly what I was expecting!

@lxjv
Copy link
Collaborator Author

lxjv commented Oct 27, 2021

thats perfect! :))

@nyakase
Copy link
Contributor

nyakase commented Oct 27, 2021

i agree with @chxseh here, that's what i was expecting as well
granual permissions would be cool but could be added later

@newbold newbold closed this as completed Aug 14, 2022
@lxjv lxjv reopened this Oct 12, 2022
@lxjv
Copy link
Collaborator Author

lxjv commented Oct 12, 2022

@newbold we could use this for the updates blog and stuff!

@lxjv lxjv pinned this issue Oct 12, 2022
@lxjv lxjv changed the title allow more than one person to control an omg.lol address Allow more than one owner/account per omg.lol address Oct 12, 2022
@neatnik neatnik deleted a comment from newbold Oct 13, 2022
@newbold newbold unpinned this issue Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Related to the core omg.lol service enhancement New feature or request
Development

No branches or pull requests

5 participants