Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix authentication for miners with no ethernet #449

Closed
shawaj opened this issue Jan 15, 2023 · 2 comments · Fixed by #461
Closed

Fix authentication for miners with no ethernet #449

shawaj opened this issue Jan 15, 2023 · 2 comments · Fixed by #461
Assignees

Comments

@shawaj
Copy link
Member

shawaj commented Jan 15, 2023

A couple of miners (Finestra for example) do not have ethernet.

In that case, we should use the WiFi Mac address

eth_mac = diagnostics.get('E0')
default_password = eth_mac.replace(':', '')
password_row = write_password(default_password)
return password_row

Or perhaps we use the MAC key from hardware definitions as the default:
https://github.com/NebraLtd/hm-pyhelper/blob/8fa184c6026c5f9009fc61ea583883679fed5057/hm_pyhelper/hardware_definitions.py#L54

And if there is not one then fall back to eth, and if not eth then fall back to WiFi.

What do you think @robputt ?

@pritamghanghas
Copy link
Contributor

@shawaj There is another issue with the mac address as password. Our thermal labels fade away overtime. In such a case, the user has to find his mac from his internet router. Assuming he knows how and where to look for mac of connected devices.

@shawaj
Copy link
Member Author

shawaj commented Jan 18, 2023

@pritamghanghas I think finding it from router is probably an acceptable amount of effort. We also include 2 additional spare serial number stickers in the box with the miner, as well as the one attached to the miner itself. Also our tech support can probably help people get it as well.

I'm not sure what other default we could use though? And we need the auth to enable other features.

@KevinWassermann94 @NebraLtd/developers any other thoughts on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants