Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Percentage error on relayed device? #52

Closed
shawaj opened this issue Jun 3, 2021 · 5 comments
Closed

Percentage error on relayed device? #52

shawaj opened this issue Jun 3, 2021 · 5 comments

Comments

@shawaj
Copy link
Member

shawaj commented Jun 3, 2021

This is a device that had been online for some time (many days), but is stuck syncing. Shows really high percentage and that blockchain is only on block 1

Screenshot 2021-06-03 at 23 31 13

@shawaj
Copy link
Member Author

shawaj commented Jun 3, 2021

this is the device in freshdesk ticket #244346

@ryanteck
Copy link
Contributor

ryanteck commented Jun 3, 2021

I don't really see the issue, it stays at 1 if it is unable to request it from the Helium API.

Some value needs to be there, when it was 0 it caused errors due to dividing by zero to get the percentage.

I can add a cap to the percentage maybe. But otherwise it's working as intended.

@ryanteck ryanteck closed this as completed Jun 3, 2021
@shawaj
Copy link
Member Author

shawaj commented Jun 3, 2021

IMO it would be better to have it say something like an error message instead of 1. Something like "Waiting for block from Helium" or similar so that it is obvious.

And to just show a similar error message in the percentage.

Otherwise it just looks like a bug to someone that doesn't know

@shawaj shawaj reopened this Jun 3, 2021
@ryanteck
Copy link
Contributor

ryanteck commented Jun 8, 2021

Possibly could do similar to what I've just suggested in #50 which is that if it detects it is 1 then it'll display a message like that.

ryanteck added a commit that referenced this issue Jun 9, 2021
@ryanteck
Copy link
Contributor

ryanteck commented Jun 9, 2021

I've added a test in so if it is < 1% (Either just setup or powered on) that it will show as miner is still loading.

The same for if the percentage is > 100%

Screenshot from 2021-06-09 11-50-40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants