Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If two players connects at the same time, they will not see each other #63

Closed
Baldie-dev opened this issue Mar 21, 2021 · 2 comments · Fixed by #85
Closed

If two players connects at the same time, they will not see each other #63

Baldie-dev opened this issue Mar 21, 2021 · 2 comments · Fixed by #85
Assignees
Labels
bug Something isn't working

Comments

@Baldie-dev
Copy link
Contributor

When two players connect at the same time, they will not see each other and the "Loading" message will freeze on the Host side:

bug

@hubastard hubastard added the bug Something isn't working label Mar 21, 2021
@hubastard
Copy link
Collaborator

Yeah, we will need to make a pending player queue and make sure only send the PlayerSyncComplete packet once all the pending players are done loading.

@Mushroom
Copy link
Contributor

I had this in mind when I created the "pendingPlayers" list during the handshake phase, so it should be easy to modify it to do as required

@hubastard hubastard self-assigned this Mar 22, 2021
@hubastard hubastard linked a pull request Mar 27, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants