[SOD] Something is wrong with the 'icon' code in CombatEvents.lua making the app crash

[Larzie]

Since the new phase (phase 3). Something is wrong with the icon code in CombatEvents.lua. The codechanges below make the addon work again, but it removes the icons from the scroll areas ofc.

Change line 2066 from this:
icon = icon(info)

To this:
-- icon = icon(info)

Do you see why icon(info) doesn't work anymore?

Thank you so much <3

[nteetor]

I have experienced this as well. It's not consistent for me and a /reload does reset the problem. I can only guess trying to look up a certain icon from something new to Phase 3 causes the error.

[nebularg]

Thanks, I'll push some quick fixes for this and work on combining the classic/retail version since it looks like a lot of the cruft needed for classic era has gone away (and is now causing problems)

[nteetor]

Awesome, thank you. I'll reply if I see the problem again.