Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 19 support #2686

Open
1 task done
pierpo opened this issue Jun 12, 2024 · 1 comment
Open
1 task done

React 19 support #2686

pierpo opened this issue Jun 12, 2024 · 1 comment
Labels
enhancement Requires extension or creation of new React Native API

Comments

@pierpo
Copy link

pierpo commented Jun 12, 2024

Is there an existing request?

  • I have searched for this request

Describe the feature request

Hey,

I just tried setting up React 19 on my React Native Web project.

It doesn't work yet, as the following functions are not found anymore:

  • unmountComponentAtNode in src/exports/unmountComponentAtNode/index.js
  • domLegacyRender in src/exports/render/index.js
  • domLegacyHydrate in src/exports/render/index.js
  • findDOMNode in src/exports/findNodeHandle/index.js

They were deprecated with React 18 and won't work with React 19.

(Sorry, I haven't found any other topic mentioning the React 19 support)

Thanks 🙌

@pierpo pierpo added the enhancement Requires extension or creation of new React Native API label Jun 12, 2024
@necolas
Copy link
Owner

necolas commented Jun 13, 2024

  1. Use mode:concurrent => https://necolas.github.io/react-native-web/docs/app-registry/#appparams
  2. Stop using findNodeHandle

I don't know what other changes are needed for React 19, but will review PRs as long as they don't break React 18 support. Any other issues are probably going to be traced back to React Native's APIs (e.g., findNodeHandle is being preserved in Fabric but has no analog in React DOM because of the removal of findDOMNode) and 3P libraries not being web compatible given the changes React is undergoing on web.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requires extension or creation of new React Native API
Projects
None yet
Development

No branches or pull requests

2 participants