Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Modal component #411

Closed
wants to merge 1 commit into from
Closed

Add Modal component #411

wants to merge 1 commit into from

Conversation

jhen0409
Copy link
Contributor

@jhen0409 jhen0409 commented Apr 4, 2017

This patch solves the following problem

#91 Modal component

Test plan

This pull request

  • includes documentation
  • includes tests
  • includes benchmark reports
  • includes an interactive example
  • includes screenshots/videos

@ndbroadbent
Copy link
Contributor

Oh awesome, I was just looking for this so that I could get react-native-material-dialog working on web.

I would love to help test this, but it looks like there's a conflict that needs to be fixed.

@necolas
Copy link
Owner

necolas commented Apr 23, 2017

I think the animations could be implemented as CSS transitions (for performance).

While this is a good start, I think the Modal implementation will be more complicated than this as it needs to be rendered outside the tree of your main app (i.e., probably requires working into the AppRegistry root view) in order to get the stacking correct and to support launching modals from within any layer context (e.g., a ScrollView or anything else using translate3d)

@jefferscn jefferscn mentioned this pull request May 8, 2017
5 tasks
@jhen0409
Copy link
Contributor Author

jhen0409 commented May 8, 2017

Move to #471.

Sorry I haven't so much time for look this. :|

@jhen0409 jhen0409 closed this May 8, 2017
@jhen0409 jhen0409 deleted the modal branch May 8, 2017 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants