Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal Component #471

Closed
wants to merge 16 commits into from
Closed

Modal Component #471

wants to merge 16 commits into from

Conversation

jefferscn
Copy link

This patch solves the following problem
#91 Modal Component

  • use react-transition-group to implement animation.
  • for some problem when modal renders in a fixed element in browser(specially Safari),We render the modal root element out of the main app tree.Create a new div under body,then render all modal conent into this div.
  • document is copied from Add Modal component #411

Test plan

  • default value test
  • root element test

This pull request

  • includes documentation
  • includes tests
  • includes benchmark reports
  • includes an interactive example
  • includes screenshots/videos

@jhen0409 jhen0409 mentioned this pull request May 8, 2017
5 tasks
@vaukalak
Copy link
Contributor

vaukalak commented Jun 2, 2017

Does anyone know what is the status of this PR, and if the help is needed on that?

@piranna
Copy link

piranna commented Oct 3, 2017

Can somebody fix the conflicts an merge it upstream?

@jefferscn jefferscn closed this Oct 10, 2017
@piranna
Copy link

piranna commented Oct 10, 2017

By clossing this, does it means it's upstream already and published on npm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants