You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This throws an IllegalArgumentException instead of an AQLValidationException as other validate methods do. Please catch the IllegalArgumentException and convert it to an AQLValidationException.
Some of these attributes are also attributes on other RM classes, e.g. language is also an attribute on OBSERVATION and DV_TEXT. Can't this be solved another way?
Then this class doesn't need to extend AQLBaseVisitor anymore and private Lookup lookup;, the constructor and public QOMObject visitChildren(RuleNode node) { ... } can be removed.
The text was updated successfully, but these errors were encountered:
My first round of feedback:
aqlparser/src/main/java/com/nedap/healthcare/aqlparser/exception/AQLUnsupportedFeatureException.java
Line 5 in 233735b
This is unused.
aqlparser/src/main/java/com/nedap/healthcare/aqlparser/exception/AQLValidationException.java
Lines 5 to 7 in 233735b
This is unused.
aqlparser/src/main/java/com/nedap/healthcare/aqlparser/model/leaf/ArchetypeId.java
Lines 12 to 15 in 233735b
This throws an
IllegalArgumentException
instead of anAQLValidationException
as othervalidate
methods do. Please catch theIllegalArgumentException
and convert it to anAQLValidationException
.aqlparser/src/main/java/com/nedap/healthcare/aqlparser/model/leaf/IdentifiedExprOperand.java
Lines 65 to 67 in 233735b
This is unused. I'm not sure why.
aqlparser/src/main/java/com/nedap/healthcare/aqlparser/model/leaf/ObjectPath.java
Lines 32 to 46 in 233735b
Some of these attributes are also attributes on other RM classes, e.g.
language
is also an attribute onOBSERVATION
andDV_TEXT
. Can't this be solved another way?aqlparser/src/main/java/com/nedap/healthcare/aqlparser/model/leaf/Operator.java
Lines 6 to 7 in 233735b
These are unused.
aqlparser/src/main/java/com/nedap/healthcare/aqlparser/model/leaf/Operator.java
Lines 22 to 24 in 233735b
This is unused.
aqlparser/src/main/java/com/nedap/healthcare/aqlparser/model/Lookup.java
Lines 61 to 63 in 233735b
I don't think this works. I think you mean
aqlparser/src/main/java/com/nedap/healthcare/aqlparser/model/NodeExpression.java
Line 149 in 233735b
This is unused.
All
protected
methods inNodeExpression
can be changed toprivate
.aqlparser/src/main/java/com/nedap/healthcare/aqlparser/parser/QOMParser.java
Lines 52 to 53 in 233735b
can be changed to
Then this class doesn't need to extend
AQLBaseVisitor
anymore andprivate Lookup lookup;
, the constructor andpublic QOMObject visitChildren(RuleNode node) { ... }
can be removed.The text was updated successfully, but these errors were encountered: