Pagination params fix #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neet
reviewed
Nov 25, 2022
src/paginator.ts
Outdated
| @@ -37,6 +37,7 @@ export class Paginator<Params, Result> | |||
| typeof response.headers?.link === 'string' | |||
| ? this.pluckNext(response.headers.link) | |||
| : undefined; | |||
| this.nextParams = {}; | |||
There was a problem hiding this comment.
Typecheck seems to be failing. You can just add downcasting such as {} as Params for now
This stops the duplication of query parameters in our request URL, as Mastodon already gives us the correct parameters in the `Link` header. In some cases, a mixture of parameters from `params` and the `Link` URL could cause the iterator to get caught in an infinite loop. Fixes neet#698.
…rameters Now that query parameter duplication has been fixed, users should be able to safely use `maxId` and `sinceId` in their code. Fixes neet#698.
SuperSonicHub1
force-pushed
the
pagination-params-fix
branch
from
f866f53
to
257359e
Compare
neet
added a commit
that referenced
this pull request
Nov 25, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Nov 26, 2022
## [4.6.9](v4.6.8...v4.6.9) (2022-11-26) ### Bug Fixes * Actually send user-specified headers in `HttpAxiosImpl` ([b602fe4](b602fe4)), closes [#697](#697) * Encode URI components in serializer ([8a2be08](8a2be08)) * **fetch:** Normalize header to be lowercase ([f7fce11](f7fce11)) * Fix failing test in [#702](#702) ([a2a4c26](a2a4c26)) * read next link from response ([68c71bd](68c71bd)) * Set `Paginator.nextParams` to an empty object after first request ([4ce57a6](4ce57a6)), closes [#698](#698) * Unmark `DefaultPaginationParams.{maxId, sinceId}` as internal parameters ([257359e](257359e)), closes [#698](#698) * Update Notification.type types ([#706](#706)) ([50c5c5c](50c5c5c))
|
🎉 This PR is included in version 4.6.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #698.