Added UI Design for App #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @malakar-swastik I would request some changes
|
|
Okay sure.
…On Thu, Oct 1, 2020, 13:46 Anushka Shukla ***@***.***> wrote:
Hi @malakar-swastik <https://github.com/malakar-swastik> I would request
some changes
- Kindly remove the readme file from the UI Design Drafts folder as we
already have one and we do not need that when it will be merged. for
anything to ask or state do comment in the thread itself.
- Rename the names of the ".png" files to more specific one like
"LOGIN.png" or "HOME.png".
- Kindly resize the images if possible.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#10 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJ3BF4YY6R2DPERVA6Q3IMLSIQ3HHANCNFSM4SABOC2Q>
.
|
|
@malakar-swastik keep the authentication and login files and remove the rest as they are in conflict with the vision of our app. Also, can you add just the logo separately? |
|
Okay sure.
…On Fri, Oct 2, 2020, 10:11 Neil ***@***.***> wrote:
@malakar-swastik <https://github.com/malakar-swastik> keep the
authentication and login files and remove the rest as they are in conflict
with the vision of our app. Also, can you add just the logo separately?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#10 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJ3BF46IFXME5P627AKEZBTSIVKYNANCNFSM4SABOC2Q>
.
|
|
@malakar-swastik I have merged your PR, however, a small change has to be made. In login.png, remove "Create Account? Sign up" line and change "login button" to "Signin". |
|
Cool. Will do.
…On Fri, Oct 2, 2020, 18:44 Neil ***@***.***> wrote:
@malakar-swastik <https://github.com/malakar-swastik> I have merged your
PR, however, a small change has to be made. In login.png, remove "Create
Account? Sign up" line and change "login button" to "Signin".
In the authentication.png file add a "Verify" button below the text field.
Also change the text field to six separate boxes, each for one OTP digit.
Make these changes and create a new PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#10 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJ3BF4ZHEKCXWQ467R7YT3TSIXG4JANCNFSM4SABOC2Q>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the UI Design for App. However, since no logo was available, I have used a default placeholder .