Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hv note doesn't append to existing note #13

Open
ericboehs opened this issue May 6, 2014 · 8 comments · May be fixed by #14
Open

hv note doesn't append to existing note #13

ericboehs opened this issue May 6, 2014 · 8 comments · May be fixed by #14

Comments

@ericboehs
Copy link

hv note 1234567 → Testing 123
hv note 1234567 → Testing 456

My time entry shows:

Testing 456

when I'd prefer it'd be

Testing 123
Testing 456

This is how the hcl gem does it and is what I would expect.

@ericboehs
Copy link
Author

Oops. Created issue prematurely. Updated.

@neilrenicker
Copy link
Owner

@ericboehs notes should append. Just double checked, works as requested for me.

You working off the latest version? https://github.com/neilrenicker/alfred-harvest/releases

@ericboehs
Copy link
Author

I am. I just installed it for the first time today. Checking the latest commit to master against my workflow's source matches up too.

@ericboehs
Copy link
Author

Looking at post_note.php#L31 it just replaces the <notes> value with what is provided by Alfred (doesn't append to previous note). And according to the harvest docs "values are overwritten for the day entry with the data provided in your request".

I'd assume you need to include get_daily.php and then append the new note to the existing note (similar to how hcl does it).

@neilrenicker
Copy link
Owner

That's exactly what I'm doing here https://github.com/neilrenicker/alfred-harvest/blob/master/commands/note.php#L122. Does this happen consistently for you? If it happened only the first time, I'd suspect it to be a caching issue.

@ericboehs
Copy link
Author

Ah! Hmm now it seems to be working. Even though I tried it several times before I posted this issue.

Well now I'd just suggest appending new lines between each note.

@ericboehs
Copy link
Author

I got it! It's if you use Alfred's "Store typed query history" or use the up arrow to bring up previous commands (something I do frequently).

@ericboehs ericboehs reopened this May 6, 2014
@neilrenicker
Copy link
Owner

Interesting. I didn't know about that Alfred feature. I'll consider forcing new lines on notes. Thanks for the feedback.

@ericboehs ericboehs linked a pull request May 6, 2014 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants