refactor: GITHUB_ENV command / remove env.PATH #1503

ChristopherHX · 2022-12-11T21:02:12Z

I'm potentially breaking non standard act specfic workflows

With this change are all file commands in a single place again.

Closes #1384
Closes #1421

github-actions · 2022-12-12T19:01:07Z

🦙 MegaLinter status: ✅ SUCCESS

Descriptor	Linter	Files	Errors	Elapsed time
✅ EDITORCONFIG	editorconfig-checker	12	0	0.04s
✅ REPOSITORY	gitleaks	yes	no	2.41s
✅ REPOSITORY	git_diff	yes	no	0.0s
✅ REPOSITORY	secretlint	yes	no	0.98s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by

codecov · 2022-12-12T20:28:37Z

Codecov Report

Merging #1503 (3237a13) into master (4989f44) will increase coverage by 0.68%.
The diff coverage is 75.44%.

@@            Coverage Diff             @@
##           master    #1503      +/-   ##
==========================================
+ Coverage   61.22%   61.91%   +0.68%     
==========================================
  Files          46       46              
  Lines        7141     7246     +105     
==========================================
+ Hits         4372     4486     +114     
+ Misses       2462     2457       -5     
+ Partials      307      303       -4

Impacted Files	Coverage Δ
pkg/container/docker_cli.go	`82.23% <ø> (ø)`
pkg/container/docker_logger.go	`52.08% <ø> (ø)`
pkg/container/docker_pull.go	`33.33% <ø> (ø)`
pkg/container/docker_run.go	`13.58% <ø> (ø)`
pkg/container/docker_volume.go	`0.00% <ø> (ø)`
pkg/container/docker_images.go	`27.02% <29.41%> (-4.13%)`	⬇️
pkg/model/github_context.go	`61.06% <32.00%> (-19.40%)`	⬇️
pkg/container/docker_auth.go	`51.35% <56.25%> (+3.73%)`	⬆️
pkg/runner/runner.go	`86.45% <66.66%> (-2.05%)`	⬇️
pkg/runner/step.go	`83.33% <75.00%> (+0.36%)`	⬆️
... and 19 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

ChristopherHX

I got it working, inclusive tests for custom PATH in docker actions etc.

pkg/runner/action_composite.go

pkg/runner/run_context.go

ChristopherHX · 2022-12-12T20:26:42Z

pkg/runner/step.go

-	err := rc.JobContainer.UpdateFromImageEnv(step.getEnv())(ctx)
-	if err != nil {
-		return err
-	}


This add PATH to the env object, but in actions/runner env.PATH is empty

ChristopherHX · 2022-12-12T20:27:49Z

pkg/runner/testdata/docker-action-custom-path/push.yml

+    - run: |
+        FROM ubuntu:latest
+        ENV PATH="/opt/texlive/texdir/bin/x86_64-linuxmusl:${PATH}"
+        ENV ORG_PATH="${PATH}"


ORG_PATH is a copy of the expected PATH value, this enshures PATH is unset in env ctx for docker actions

ChristopherHX · 2022-12-12T20:28:48Z

pkg/runner/testdata/remote-action-js-node-user/push.yml

+    runs-on: ubuntu-latest
+    container:
+      image: node:16-buster-slim
+      options: --user node


The previous non root user image has PATH issues with node, due to intentional changes.

mergify · 2022-12-15T16:46:03Z

@ChristopherHX this pull request is now in conflict 😩

KnisterPeter

Looks good.

ChristopherHX · 2022-12-21T20:21:31Z

@catthehacker provided some details about the act images I didn't know, so this PR should be blocked for now to not break users.

This PR removes also reading other envs than PATH from /etc/environment, so this break everything for these images.

ChristopherHX · 2023-01-18T16:24:52Z

I opened a PR to the act docker images repo catthehacker/docker_images#83 to resolve the issues caused by this PR.

I'm not shure how to enshure that docker images are semi uptodate, because this is a breaking change for the docker_images repo.

Oh no recent changes to branch protection rules, made the update branch button disappear, GitHub settings are fixed

catthehacker · 2023-01-19T18:25:28Z

I'm not shure how to enshure that docker images are semi uptodate, because this is a breaking change for the docker_images repo.

What do you mean?

ChristopherHX · 2023-01-19T18:53:26Z

I mean act doesn't pull images by default. Some may end up creating an issue about missing node in PATH.

catthehacker · 2023-01-19T18:56:38Z

Change so it pulls by default 😛

or add feature that fetches latest meta about used image and warn user when image is outdated/doesn't match

See #1585 for a test

ChristopherHX · 2023-01-31T16:24:36Z

I added more tests and fixed an issue, which leaked the step env of the composite actions.

You can now define env variables with the same name as a env var in the step env as new global variables, tests has been added.

I hope this PR doesn't cause new issues and I think this is ready now.

mergify · 2023-01-31T16:37:14Z

@ChristopherHX this pull request has failed checks 🛠

No, only coverage upload failed with a weird error.

pull-request-size bot added the size/M label Dec 11, 2022

Anastasia1510 approved these changes Dec 11, 2022

View reviewed changes

Anastasia1510 previously approved these changes Dec 11, 2022

View reviewed changes

ChristopherHX dismissed Anastasia1510’s stale review via c98197f December 11, 2022 22:59

fix: GITHUB_ENV / PATH handling

65b339a

ChristopherHX force-pushed the fix-GITHUB_ENV-path-handling branch from 2f9d59c to 65b339a Compare December 12, 2022 19:41

pull-request-size bot added size/L and removed size/M labels Dec 12, 2022

ChristopherHX changed the title ~~fix: GITHUB_ENV / PATH handling for docker container~~ fix: GITHUB_ENV / PATH handling Dec 12, 2022

apply workaround

9fe22f7

ChristopherHX marked this pull request as ready for review December 12, 2022 20:29

ChristopherHX requested a review from a team as a code owner December 12, 2022 20:29

ChristopherHX commented Dec 12, 2022

View reviewed changes

ChristopherHX mentioned this pull request Dec 12, 2022

Add node to PATH in an actions/runner compatible way catthehacker/docker_images#81

Closed

ChristopherHX changed the title ~~fix: GITHUB_ENV / PATH handling~~ refactor: fix GITHUB_ENV / PATH handling Dec 12, 2022

add ctx to ApplyExtraPath

f696467

mergify bot added the conflict PR has conflicts label Dec 15, 2022

ChristopherHX changed the title ~~refactor: fix GITHUB_ENV / PATH handling~~ refactor: GITHUB_ENV command / remove env.PATH Dec 16, 2022

Merge branch 'master' into fix-GITHUB_ENV-path-handling

7de02e2

mergify bot added needs-work Extra attention is needed and removed conflict PR has conflicts labels Dec 18, 2022

nektos deleted a comment from mergify bot Dec 18, 2022

KnisterPeter previously approved these changes Dec 19, 2022

View reviewed changes

mergify bot removed the needs-work Extra attention is needed label Dec 19, 2022

ChristopherHX mentioned this pull request Dec 20, 2022

fix: use correct path to toolcache #1494

Merged

ChristopherHX marked this pull request as draft December 21, 2022 20:20

ChristopherHX marked this pull request as ready for review January 18, 2023 16:23

Merge branch 'master' into fix-GITHUB_ENV-path-handling

a8e7aba

ChristopherHX mentioned this pull request Jan 19, 2023

refactor: pull and rebuild docker images by default #1569

Merged

ChristopherHX added 2 commits January 20, 2023 17:16

Merge branch 'master' into fix-GITHUB_ENV-path-handling

8bde9c5

Merge branch 'master' into fix-GITHUB_ENV-path-handling

9c69677

ChristopherHX marked this pull request as draft January 26, 2023 22:24

fix: Do not leak step env in composite

7df1125

See #1585 for a test

ChristopherHX dismissed KnisterPeter’s stale review via 7df1125 January 26, 2023 23:05

ChristopherHX added 3 commits January 29, 2023 16:39

Merge branch 'master' into fix-GITHUB_ENV-path-handling

3a87cce

add more tests

b44d6e3

Merge branch 'master' into fix-GITHUB_ENV-path-handling

3742838

ChristopherHX marked this pull request as ready for review January 31, 2023 16:24

mergify bot added the needs-work Extra attention is needed label Jan 31, 2023

Merge branch 'master' into fix-GITHUB_ENV-path-handling

612b445

mergify bot removed the needs-work Extra attention is needed label Feb 1, 2023

mergify bot requested a review from a team February 1, 2023 16:48

KnisterPeter approved these changes Feb 2, 2023

View reviewed changes

catthehacker approved these changes Feb 4, 2023

View reviewed changes

Merge branch 'master' into fix-GITHUB_ENV-path-handling

3237a13

mergify bot merged commit e775fea into master Feb 4, 2023

mergify bot deleted the fix-GITHUB_ENV-path-handling branch February 4, 2023 13:35

ChristopherHX mentioned this pull request Feb 8, 2023

Issue: Docker env PATH lost #896

Open

frankplow mentioned this pull request Feb 11, 2023

Action not working with act xanderhendriks/action-build-stm32cubeide#4

Closed

glimchb mentioned this pull request Jul 10, 2024

Issue: exec: "node": executable file not found in $PATH: unknown #973

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: GITHUB_ENV command / remove env.PATH #1503

refactor: GITHUB_ENV command / remove env.PATH #1503

ChristopherHX commented Dec 11, 2022 •

edited

Loading

github-actions bot commented Dec 12, 2022 •

edited

Loading

codecov bot commented Dec 12, 2022 •

edited

Loading

ChristopherHX left a comment

ChristopherHX Dec 12, 2022

ChristopherHX Dec 12, 2022

ChristopherHX Dec 12, 2022

mergify bot commented Dec 15, 2022

KnisterPeter left a comment

ChristopherHX commented Dec 21, 2022 •

edited

Loading

ChristopherHX commented Jan 18, 2023 •

edited

Loading

catthehacker commented Jan 19, 2023

ChristopherHX commented Jan 19, 2023

catthehacker commented Jan 19, 2023

ChristopherHX commented Jan 31, 2023

mergify bot commented Jan 31, 2023 •

edited by ChristopherHX

Loading

refactor: GITHUB_ENV command / remove env.PATH #1503

refactor: GITHUB_ENV command / remove env.PATH #1503

Conversation

ChristopherHX commented Dec 11, 2022 • edited Loading

github-actions bot commented Dec 12, 2022 • edited Loading

🦙 MegaLinter status: ✅ SUCCESS

codecov bot commented Dec 12, 2022 • edited Loading

Codecov Report

ChristopherHX left a comment

Choose a reason for hiding this comment

ChristopherHX Dec 12, 2022

Choose a reason for hiding this comment

ChristopherHX Dec 12, 2022

Choose a reason for hiding this comment

ChristopherHX Dec 12, 2022

Choose a reason for hiding this comment

mergify bot commented Dec 15, 2022

KnisterPeter left a comment

Choose a reason for hiding this comment

ChristopherHX commented Dec 21, 2022 • edited Loading

ChristopherHX commented Jan 18, 2023 • edited Loading

catthehacker commented Jan 19, 2023

ChristopherHX commented Jan 19, 2023

catthehacker commented Jan 19, 2023

ChristopherHX commented Jan 31, 2023

mergify bot commented Jan 31, 2023 • edited by ChristopherHX Loading

ChristopherHX commented Dec 11, 2022 •

edited

Loading

github-actions bot commented Dec 12, 2022 •

edited

Loading

codecov bot commented Dec 12, 2022 •

edited

Loading

ChristopherHX commented Dec 21, 2022 •

edited

Loading

ChristopherHX commented Jan 18, 2023 •

edited

Loading

mergify bot commented Jan 31, 2023 •

edited by ChristopherHX

Loading