Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: pull and rebuild docker images by default #1569

Merged
merged 2 commits into from
Jan 20, 2023

Conversation

ChristopherHX
Copy link
Contributor

#1503 requires that medium and large act images are uptodate.

It has been an issue that docker action images are not rebuild.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 1 0 0.01s
✅ REPOSITORY gitleaks yes no 2.63s
✅ REPOSITORY git_diff yes no 0.0s
✅ REPOSITORY secretlint yes no 0.84s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #1569 (efbb890) into master (4989f44) will increase coverage by 0.71%.
The diff coverage is 77.40%.

@@            Coverage Diff             @@
##           master    #1569      +/-   ##
==========================================
+ Coverage   61.22%   61.93%   +0.71%     
==========================================
  Files          46       46              
  Lines        7141     7185      +44     
==========================================
+ Hits         4372     4450      +78     
+ Misses       2462     2428      -34     
  Partials      307      307              
Impacted Files Coverage Δ
pkg/container/docker_cli.go 82.23% <ø> (ø)
pkg/container/docker_logger.go 52.08% <ø> (ø)
pkg/container/docker_pull.go 33.33% <ø> (ø)
pkg/container/docker_run.go 13.58% <ø> (ø)
pkg/container/docker_volume.go 0.00% <ø> (ø)
pkg/runner/run_context.go 78.81% <0.00%> (ø)
pkg/container/docker_images.go 27.02% <29.41%> (-4.13%) ⬇️
pkg/container/docker_auth.go 51.35% <56.25%> (+3.73%) ⬆️
pkg/runner/runner.go 86.45% <66.66%> (-2.05%) ⬇️
pkg/common/git/git.go 57.72% <79.71%> (+7.72%) ⬆️
... and 11 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ChristopherHX ChristopherHX marked this pull request as ready for review January 19, 2023 20:17
@ChristopherHX ChristopherHX requested a review from a team as a code owner January 19, 2023 20:17
@ChristopherHX ChristopherHX changed the title refactor: pull and rebuild docker by default refactor: pull and rebuild docker images by default Jan 19, 2023
@mergify mergify bot merged commit b00babd into master Jan 20, 2023
@mergify mergify bot deleted the refactor-pull-rebuild branch January 20, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants