-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider using a dynamic config.json to handle settings #35
Comments
I forgot to mention that I did see Issue #26, but I'm not sure what the status is on that endeavor, this issue proposes a different solution entirely, and I believe this offers a better alternative. |
I recently added |
Actually, |
Also, #26 was originally created to be used in conjunction with eventual Docker support and not manual usage. Though people would be free to do so. |
Yeah, any options that CAN be configured from the config file should definitely be designated to it, it allows much more consistency for the person configuring and greater freedom to extend those options in the future. It also simplified the process of configuring andesite to be launched as a service using Linux’s systemd or Windows Services.
… On Jun 4, 2019, at 3:49 PM, Meghan Denny ***@***.***> wrote:
I recently added --use-home true which places the config.json inside of ~/.config/andesite/. Is this a suggestion to also be able to set --root, --port, and others from inside the config file? Just clarifying before I move forward.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
The Andesite executable can now be launched with no CLI arguments and is able to read all config info from the respective properties inside |
I think requiring CLI arguments to function properly is not an ideal configuration strategy for what essentially amounts to a service. I propose the following:
--config
that will allow you to declare the location of config.json dynamically~/.andesite/config.json
This strategy is very typical for applications of this nature.
The text was updated successfully, but these errors were encountered: