Clicking in other windows deselects nodes

[Atrix256]

I have a property panel that shows info for the selected node, but whenever i click on the property panel, the selected nodes are cleared due to this code in EndNodeEditor() (like 1343)

    // check to see if the mouse was near any node
    if (g.node_hovered == INVALID_INDEX)
    {
        if (is_mouse_clicked)
        {
            editor.selected_nodes.clear();
        }
    }

Changing the if to this fixes my issue. Is this correct / should i submit a pull request?

    // check to see if the mouse was near any node
    if (g.node_hovered == INVALID_INDEX && ImGui::IsWindowHovered())
    {
        if (is_mouse_clicked)
        {
            editor.selected_nodes.clear();
        }
    }

[Nelarius]

Good catch, that's definitely an annoying issue. The change you submitted will fix it -- although you should do it for editor.selected_links as well a few lines further down in the code. If you have the change lying around still, feel free to submit a pr! 👍

[Atrix256]

Ok cool thanks! I'll submit a PR

…

On Thu, Feb 20, 2020, 10:22 PM Johann Muszynski ***@***.***> wrote: Good catch, that's definitely an annoying issue. The change you submitted will fix it -- although you should do it for editor.selected_links as well a few lines further down in the code. If you have the change lying around still, feel free to submit a pr! 👍 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#22?email_source=notifications&email_token=AARSRF4O4TPLS4KPW3BKRV3RD5XJJA5CNFSM4KY4AAE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMRU5FI#issuecomment-589516437>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AARSRF5RQJV4ZT2GX27DYVDRD5XJJANCNFSM4KY4AAEQ> .

[Atrix256]

PR submitted: #23