Reme isn't reported as saved even if you leave Bontom with having freed him

[cooljeanius]

To reproduce: Start Bontom, leave Reme caged, and then move Gawen to the signpost and tell him to retreat. Reme will still be freed even though he's not supposed to be. I think the issue here is in the {NEXT_SCENARIO_CONTINUE} macro...

[Toranks]

Be cautious with the use of [allow_undo] on events that can change variables. Must be related. When I get to that part I'll try it.

[cooljeanius]

I don't think the [allow_undo] is related, I think it has to do with porting from a previous version where the {NEXT_SCENARIO_CONTINUE} macro would end the level with status continue instead of victory, but since that's no longer an option, it has to be victory instead, which triggers the victory event...

[cooljeanius]

When I get to that part I'll try it.

So... did you find anything out?

[Toranks]

A_New_Order/scenarios/14b_Bontom.cfg

Line 896 in b0f6ab0

name=victory

In ELSE you must put the conversation and code that should occur when Reme is NOT released. Also, you don't need to include the ability to recruit Akladians here, that already happens when Reme is released. So delete that allow_recruit and {VARIABLE ano_reme_saved yes}.

[Toranks]

I think this is all you need. The rest of the dialogue already happens when you release Reme on the other situations:

    [event]
        name=victory
		[filter_condition]
			{VARIABLE_CONDITIONAL ano_reme_saved equals yes}
		[/filter_condition]
        {MSG_Reme _"The outlaws are defeated!"}
    [/event]

[cooljeanius]

I think this is all you need. The rest of the dialogue already happens when you release Reme on the other situations:

    [event]
        name=victory
		[filter_condition]
			{VARIABLE_CONDITIONAL ano_reme_saved equals yes}
		[/filter_condition]
        {MSG_Reme _"The outlaws are defeated!"}
    [/event]

Have you tested?

[Toranks]

No, when I wrote it I was way ahead on the campaign, but I read the code well and by changing that event by shortening it, it is resolved, since the ano_reme_saved variable should not be changed to yes or in the following scenario the game will believe Reme was saved

[cooljeanius]

No, when I wrote it I was way ahead on the campaign, but I read the code well and by changing that event by shortening it, it is resolved, since the ano_reme_saved variable should not be changed to yes or in the following scenario the game will believe Reme was saved

ok, well please actually test to ensure, because sometimes code doesn't do what reading it would suggest, and then open a PR for it

[cooljeanius]

OK I think there's still something wrong here; on my current playthrough I cleared Bontom by defeating all the enemy leaders, and freed Reme from his cage in the process (but didn't evacuate him), so the scenario ended in victory, but then the story part for returning to the Scouting map played as if I'd failed to rescue him...

[cooljeanius]

OK someone else is going to have to figure this out for me, because the fix that I thought would solve this didn't actually...

[cooljeanius]

@CelticMinstrel says that a scenario-level[lua][/lua] tag might work at getting the check inserted before the story plays; of course, that'd mean rewriting the WML I wrote for 7183078 as Lua...

[CelticMinstrel]

I will quote my response to that from IRC:

Well, the easy way would be to put the WML in the [args] tag and call it via wml_utils.handle_event_commands.

[cooljeanius]

I'm trying addressing this a bit with #194 but haven't gotten around to trying the [lua][/lua] method yet; that'll have to wait for later...

[cooljeanius]

OK that's about all I think I'm going to do with this for now; retargeting to 1.8.0