Remove the cbs creation for n900 plugin, this lead to crashes on n9 ofon... #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fono init. For the latest release of ofono for Nemo Mobile, the modem fails to initialize with the isimodem driver enabled. This is due to a segmentation fault occurring in the flush of the atoms of the modem in cbs_assembly_free function. This resulted in a segmentation fault when using n900 driver. [n900] Remove cbs creation.
|
Good find! Yes, this patch https://git.merproject.org/mer-core/ofono/blob/master/0001-n900-disable-cbs.patch has never made it upstream, probably there was a reason for it (regression fear on n900?) |
| @@ -507,7 +507,7 @@ static void n900_post_online(struct ofono_modem *modem) | |||
|
|
|||
| ofono_netreg_create(modem, 0, "isimodem", isi->modem); | |||
| ofono_sms_create(modem, 0, "isimodem", isi->modem); | |||
| ofono_cbs_create(modem, 0, "isimodem", isi->modem); | |||
| /* ofono_cbs_create(modem, 0, "isimodem", isi->modem);*/ | |||
There was a problem hiding this comment.
Just commenting out without explanation looks more of a hack/unclean, possibly that's why it also never made upstream as-was in 2012.
I'm not familiar how ofono patches are proposed upstream, could you please comment more @jpoutiai ?
|
Can't reopen this pull request, creating a new one instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...o init.
For the latest release of ofono for Nemo Mobile, the modem fails to initialize
with the isimodem driver enabled. This is due to a segmentation fault occurring
in the flush of the atoms of the modem in cbs_assembly_free function. This
resulted in a segmentation fault when using n900 driver.
[n900] Remove cbs creation.