Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache throws 'open' not defined error in Python 3 #1041

Closed
xchoo opened this issue Apr 28, 2016 · 5 comments
Closed

Cache throws 'open' not defined error in Python 3 #1041

xchoo opened this issue Apr 28, 2016 · 5 comments
Labels
bug

Comments

@xchoo
Copy link
Member

xchoo commented Apr 28, 2016

After running a model in python3, the cache system throws the following error when closing down the simulation (after the model has successfully ran):

Simulation finished in 0:01:32.                                                 
Exception ignored in: <bound method CacheIndex.__del__ of <nengo.cache.CacheIndex object at 0x7f57521f8588>>
Traceback (most recent call last):
  File "/home/abruser/git/nengo/nengo/cache.py", line 110, in __del__
  File "/home/abruser/git/nengo/nengo/cache.py", line 126, in sync
  File "/home/abruser/git/nengo/nengo/cache.py", line 115, in _load_index
NameError: name 'open' is not defined
@tbekolay
Copy link
Member

Found this relevant StackOverflow question...

@tbekolay tbekolay added the bug label Apr 28, 2016
@jgosmann jgosmann mentioned this issue Apr 29, 2016
Closed
jgosmann added a commit that referenced this issue May 2, 2016
@jgosmann
Use cache as context manager.
44eb9cb 
Do not rely on __del__ which can cause problems.

Addresses #1041, #1048.
@jgosmann jgosmann mentioned this issue May 2, 2016
Merged
@jgosmann jgosmann removed their assignment May 2, 2016
@jgosmann
Copy link
Collaborator

jgosmann commented May 2, 2016

@xchoo Can you test if PR #1053 solves the problem?

jgosmann added a commit that referenced this issue May 3, 2016
@jgosmann
Use cache as context manager.
326658b 
Do not rely on __del__ which can cause problems.

Addresses #1041, #1048.
hunse pushed a commit that referenced this issue May 25, 2016
@jgosmann @hunse
Use cache as context manager
82afd45 
Do not rely on __del__ which can cause problems.

Addresses #1041, #1048.
@jgosmann
Copy link
Collaborator

jgosmann commented Jun 7, 2016

@xchoo Did PR #1053 (now merged into master) solve the problem and can this issue be closed?

@jgosmann
Copy link
Collaborator

@xchoo It's been 8 days. Can I close the issue?

@xchoo
Copy link
Member Author

xchoo commented Jun 16, 2016

Uh yup. I'll open it again if another issue arises with Python3 (I don't use it very often). 😄

@xchoo xchoo closed this as completed Jun 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tbekolay @jgosmann @xchoo