Use cache as context manager. #1053
Conversation
|
Pushed a commit to fix two PEP8 issues; this also needs a bugfix changelog entry. Aside from that looks good to me! |
|
Added the changelog entry. |
|
Cool; will merge on a second reviewer's +1. |
|
Any second reviewer available? |
| "Decoder cache could not acquire lock and was deactivated.") | ||
| self._index = {} | ||
| self.readonly = True | ||
| self._index = {} |
There was a problem hiding this comment.
Why does this default to an empty dict, rather than say None? If it were None, then you could just check for that on __exit__, rather than having to use hasattr.
There was a problem hiding this comment.
You're right. I fixed this. I guess, I was worried about having always to check whether it is None in that case, but all the code where it would be necessary doesn't get executed in that case for other reasons.
|
Other than that one little question, it's all fine by me. |
|
@hunse just a friendly reminder that this issue appears to be waiting on your OK given Jan's last modification of switching from an empty |
|
Oh yeah, that's fine. |
Do not rely on
__del__which can cause problems.Addresses #1041, #1048.