Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SPA gate and channel to target module #894

Closed
celiasmith opened this issue Nov 10, 2015 · 11 comments
Closed

Move SPA gate and channel to target module #894

celiasmith opened this issue Nov 10, 2015 · 11 comments
Assignees

Comments

@celiasmith
Copy link
Contributor

Currently the gates and channels created for actions that require them are placed in the thalamus itself. This seems to suggest a higher connectivity/bandwidth between cortex/thalamus that I think is expected. These could instead go in the target modules of those connections, having things depend more on cortical-cortical connections that are mediated by thalamus.

This does not change any models, it just places elements in different places.

@Seanny123
Copy link
Contributor

Does this imply just taking these things out of the thalamus or putting them into somewhere else as well?

@celiasmith
Copy link
Contributor Author

Yes, moving them into cortex. @tcstewar had some ideas about how to accomplish this, but basically making them go into the containing network of the target of the action was the plan. this would make 'Cortical' unnecessary, use that network structure, and allow functions on State to take care of the connections.

@s72sue s72sue self-assigned this Nov 13, 2015
@s72sue
Copy link
Contributor

s72sue commented Nov 16, 2015

I am wondering what the purpose of the bias node in the thalamus is, and where does this node get created?

@s72sue
Copy link
Contributor

s72sue commented Nov 16, 2015

Figured it out, bias node basically assists in routing and gets created in nengo.networks.Thalamus.
@celiasmith, I agree that the channels should be moved to the target module, however does moving the gates make much difference?

(a) Following is what moving only the channels looks like in the GUI:
channels shifted

(b) and following is what moving both channel and the gates looks like:
channels and gate shifted
(b) looks a bit confusing because there are two connections from thalamus to each of the components in the cortex. Keeping the gates in thalamus (as shown in (a) ) makes it look a bit more clear.

@xchoo
Copy link
Member

xchoo commented Nov 16, 2015

The thalamus bias node can be spilt up and relocated into each of the target networks.

@s72sue
Copy link
Contributor

s72sue commented Nov 23, 2015

Okay, I moved the gate, channel and the bias nodes to the target module.
However, the connections from thalamus to cortex show up only when I double click the thalamus. @tcstewar, can this be fixed on the nengo_gui side, or should I be doing the restructuring in a different way?
image

@Seanny123
Copy link
Contributor

The reason you can't see the connections is because you made the connections in the Thalamus context. If you make them outside of the context you should be able to see them. If that sentence didn't make sense to you, msg me and I'll show you in your code.

@s72sue
Copy link
Contributor

s72sue commented Nov 23, 2015

Gotcha...thanks!

@s72sue
Copy link
Contributor

s72sue commented Nov 23, 2015

Do we have any example which uses add_conv_effect method (i.e, an example which sets an action to combine two sources and send to the target)? If not, I will create my own.

@Seanny123
Copy link
Contributor

There should be some in the tests

On Sun, Nov 22, 2015 at 10:44 PM, Sugandha notifications@github.com wrote:

Do we have any example which uses add_conv_effect method (i.e, an example
which sets an action to combine two sources and send to the target)? If
not, I will create my own.


Reply to this email directly or view it on GitHub
#894 (comment).

@Seanny123
Copy link
Contributor

Resolved via #906

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants