Fix SPA gating compilation error. #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @tbekolay to be a potential reviewer |
| @@ -51,6 +51,9 @@ Release History | |||
| the Gram system. | |||
| (`#1027 <https://github.com/nengo/nengo/pull/1027>`_, | |||
| `#1019 <https://github.com/nengo/nengo/issues/1019>`_) | |||
| - Allow recurrence of the form ``a=b, b=a`` in basal ganglia SPA actions. | |||
| (`#1098 <https://github.com/nengo/nengo/issues/1098>`_, | |||
| `#1099 <https://github.com/nengo/nengo/pull/1099>`_) | |||
There was a problem hiding this comment.
Extra space at the start of this line is causing Github to render weirdly. Will fix in the merge if you don't get to it!
|
The diff is pretty small so I looked at this anyhow. It looks good to me, aside from the inline comment which I'll fix in the merge. Will merge on someone's +1, preferably @tcstewar (it's a quick one to review, I swear!) |
|
Nice fix, and understandable error. +1 from me! |
Otherwise it is built as part of a network which might build before the required gate exists. Also add a test that fails without these changes. Fixes #1098.
hunse
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #1098.
Motivation and context:
See #1098.
How has this been tested?
Added a test that reproduces the problem.
Where should a reviewer start?
Look at the test (more concise) or issue to see what the problem is, understand the comments in #1098 explaining the problem and then it should be clear how the fix solves the problem.
How long should this take to review?
Types of changes:
Checklist: