Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR makes
Signal
s pickle properly.Motivation and context:
With the
copy
branch (#984), we can now start thinking about pickling wholeModel
s. I tried this out, but the simulator steps were getting generated in random orders after reloading theModel
. I tracked this down to the fact that when we pickle signals, specifically those that are views on other signals, the pickling process (I was using thedill
package, since it is more flexible) didn't maintain views between theinitial_value
arrays of signals. Since we rely on this in theSignal.may_share_memory
function, that was failing.Interactions with other PRs:
This depends on #984.
How has this been tested?
Added a test which pickles a
Model
object and then unpickles it, ensuring that the simulation with both the original and re-created objects are the same.Where should a reviewer start?
It's quite short.
How long should this take to review?
Types of changes:
Checklist: