Matrix multiplication example fixes. #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test failure is unrelated to this ... I'll open an issue for that. |
|
LGTM. |
jgosmann
force-pushed
the
matmul-example-fixes
branch
from
e65b65c
to
7859901
Compare
|
Do I need to review this again or did you just clean up the history? |
|
Just rebased this and added a changelog entry. No need to review this again. |
|
LGTM! Merging. |
tbekolay
force-pushed
the
matmul-example-fixes
branch
from
c2f4365
to
0f02e9f
Compare
- Specify matrix order. The order matters somewhat and I think it helps understanding when this is clearly defined from the start. - Fix typo. - Use product network. To me this seems easier to understand because the reader does not need to figure out what parts are related to the matrix multiplication and which are just there to calculate products. If the reader wants to know how the product can be calculated, we have the scalar multiplication example. - Change matrix dimensions. Also fix some problems when changing the matrix dimensions.
tbekolay
force-pushed
the
matmul-example-fixes
branch
from
0f02e9f
to
befc564
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context:
I was starting to look at #431 and to understand how we do matrix multiplication in the first place I went through the example notebook and made a few changes (no need to merge all of them depending on what people think):
Interactions with other PRs:
#431 also makes some changes, some of which address the same things. This PR supersedes the changes to the notebook in #431.
How has this been tested?
Executed the whole notebook with the matrices from the last commit.
Trying a few more matrix shapes wouldn't hurt, but I haven't done that yet.Tried a bunch of other matrix shapes, all worked.How long should this take to review?
Types of changes:
Checklist: