Add function to activate direct mode. #1168
Conversation
+1 for having it in Nengo! Handy thing to have around for sure. |
nengo/utils/network.py
Outdated
| for c in network.all_connections: | ||
| if isinstance(c.pre, nengo.ensemble.Neurons): | ||
| requires_neurons.add(c.pre.ensemble) | ||
| if isinstance(c.post, nengo.ensemble.Neurons): |
There was a problem hiding this comment.
These should be c.pre_obj and c.post_obj so that you can catch situations like nengo.Connection(a.neurons[0], b.neurons[0])
|
Nice... yup, there's been a few times where I've wanted this sort of thing. I've even tried a few times to implement something like this that will also add in a bit of saturation behaviour (by modifying the function on the Connections), but never got it to a state I was happy about..... |
|
LGTM too. My inclination was to say this belongs in |
CHANGES.rst
Outdated
| @@ -53,6 +53,10 @@ Release History | |||
| `#1148 <https://github.com/nengo/nengo/pull/1148>`_) | |||
| - Tweaked ``rasterplot`` so that spikes from different neurons don't overlap. | |||
| (`#1121 <https://github.com/nengo/nengo/pull/1121>`_) | |||
| - Added ``activate_direcd_mode`` function to make it easier to activate direct | |||
|
Since I wrote this, it occured to me that this function should also handle learning rules which might require non-direct mode ensembles. |
|
Excluded learning rule ensembles from direct mode. This is now ready for a re-review. |
This function respects ensembles where neurons are required because of connections to/from neurons, or if learning rules are present, none of which are the case when setting the neuron_type in the top-level config. Closes #1111.
tbekolay
force-pushed
the
direct-mode
branch
from
da68703
to
c242c75
Compare
Motivation and context:
Sometime I want to run networks in direct mode, but some parts use connections to or from neurons. In those cases it is not possible to set the top-level
neuron_typetoDirectbecause some ensembles need to still use neurons. This PR adds a function where direct mode is only activated for ensembles where this is possible.Not sure whether this better fits into
nengo_extras, but to me it seems like something pretty basic that one might need for many networks.How has this been tested?
Added a unit test.
How long should this take to review?
Types of changes:
Checklist: