Add a config system quirks notebook #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
It's confusing that config context, not network membership, determines the defaults used by the config system. This new notebook explains that this happens, and gives some insight into why. This commit also adds a quirks folder to the set of examples, which could be a good place to put other potentially confusing aspects of Nengo. Addresses #615.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context:
#615 noted an unexpected way in which the config system works: config context matters, network membership does not. This PR attempts to explain this through a notebook, which is rendered in the documentation.
How has this been tested?
I built the documentation locally and ensured that it rendered properly.
How long should this take to review?
Types of changes:
Checklist: