Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to not normalize encoders #1267

Merged
merged 1 commit into from
Feb 28, 2017
Merged

Added option to not normalize encoders #1267

merged 1 commit into from
Feb 28, 2017

Conversation

bmorcos
Copy link
Contributor

@bmorcos bmorcos commented Feb 14, 2017

Motivation and context:
Functionality requested in #1191

How has this been tested?
Added a new test

How long should this take to review?

  • Quick (less than 40 lines changed or changes are straightforward)

Types of changes:

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have read the CONTRIBUTING.rst document.
  • N/A I have updated the documentation accordingly. (probably N/A?)
  • I have included a changelog entry.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Still to do:

Copy link
Contributor

@Seanny123 Seanny123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jgosmann
Copy link
Collaborator

I think normalize_encoders should be added to the Ensemble constructor for consistency. If we are worried about the constructor becoming too long (it is becoming quite long), we should come up with some guide lines which things go in there and which do not.

@bmorcos
Copy link
Contributor Author

bmorcos commented Feb 15, 2017

Quick Vote for where to put normalize_encoders?

👍 = put this in __init__
👎 = leave this as a property of the ensemble only

I will make the appropriate changes (if any) tomorrow

@bmorcos
Copy link
Contributor Author

bmorcos commented Feb 16, 2017

The people have spoken! (all three of you!)

LGTM

@jgosmann
Copy link
Collaborator

I added a commit changing the position of the argument, see the commit message (314171f) for more details. LGTM 🍰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants