Fix bugs with Piecewise process output shape #1362
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context:
This fixes two related bugs with the Piecewise process:
Piecewise({1: [1, 1, 1]})
would return0.0
for times < 1 (rather than[0, 0, 0]
).Piecewise({1: 1})
would return an array with shape()
for times < 1 and shape(1,)
for times >= 1,because
ravel
upsizes its inputs to at least 1d. This doesn't really produce any errors, but it'sprobably good to be consistent. I thought about adding some logic to check if the output shape
should be
()
or(1,)
, but then figured that it was probably easier/more consistent to just always havethe output of the process be an array, instead of a scalar.
I wasn't sure whether to add a changelog entry or not. Technically a bugfix, but it comes so closely on the heels of the feature release that it seems unnecessary (anyone looking at the changelog would probably be seeing both things for the first time).
How has this been tested?
Added a new test, see
test_shape_out
How long should this take to review?
Where should a reviewer start?
Types of changes:
Checklist: