Allow to slice learning rule error signal input. #1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgosmann
force-pushed
the
slice-learning-rule
branch
from
1e99845
to
daba136
Compare
|
FYI, one of the Python 2.7 tests are failing because of a test tolerance error. It seems to be minimal, but I figured you'd want to look at it. |
Seanny123
approved these changes
Nov 27, 2017
tbekolay
approved these changes
Apr 16, 2018
This makes it easier to provide multiple error signal inputs. Fixes #1365.
tbekolay
force-pushed
the
slice-learning-rule
branch
from
9518b64
to
afe8ccc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context:
#1310 added the possibility for error signals of arbitrary size in learning rules. But to combine multiple low-dimensional signal into higher-dimensional error signals, one had to got through a node. This PR adds the possibility to slice into the error signal to make this use case easier to use.
Fixes #1365.
Interactions with other PRs:
none
How has this been tested?
added a test
How long should this take to review?
Types of changes:
Checklist: