Set sim seed from network if sim seed not given. #1386
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context:
Issue #980 hasn't gotten any attention in a while, but apparently the last decision was to implement the behavior as in this PR, i.e. to set the simulator seed from the network seed if no simulator seed is given. Still seems like a good idea to me because today I was again surprised that my network with a process was behaving non-deterministic despite a network seed being set.
Fixes #980.
Interactions with other PRs:
none
How has this been tested?
added a test
How long should this take to review?
Types of changes:
Checklist: