Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set sim seed from network if sim seed not given. #1386

Merged
merged 1 commit into from
Dec 27, 2017
Merged

Set sim seed from network if sim seed not given. #1386

merged 1 commit into from
Dec 27, 2017

Conversation

jgosmann
Copy link
Collaborator

@jgosmann jgosmann commented Nov 17, 2017

Motivation and context:
Issue #980 hasn't gotten any attention in a while, but apparently the last decision was to implement the behavior as in this PR, i.e. to set the simulator seed from the network seed if no simulator seed is given. Still seems like a good idea to me because today I was again surprised that my network with a process was behaving non-deterministic despite a network seed being set.

Fixes #980.

Interactions with other PRs:
none

How has this been tested?
added a test

How long should this take to review?

  • Quick (less than 40 lines changed or changes are straightforward)

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)?
  • New feature (non-breaking change which adds functionality)?

Checklist:

  • I have read the CONTRIBUTING.rst document.
  • I have updated the documentation accordingly.
  • I have included a changelog entry.
  • I have added tests to cover my changes.
  • I have run the test suite locally and all tests passed.

@jgosmann
Copy link
Collaborator Author

Merry Christmas! 🎄

Can we get this PR merged? I once again lost a day trying to figure out why I get different results despite identical (network) seeds.

Copy link
Member

@tbekolay tbekolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merry Christmas to you as well! LGTM

And if the network seed is given.

Fixes #980.
@jgosmann
Copy link
Collaborator Author

Thanks! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

How should node/process seeds interact?
3 participants