Index lists with double references using negative indices #1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seanny123
approved these changes
Dec 29, 2017
|
There's an issue with Numpy 1.8 on Python 2.7 that should be resolved before merging. |
Seanny123
approved these changes
Jan 2, 2018
jgosmann
force-pushed
the
negative-indices
branch
from
7018f08
to
e05a1e3
Compare
|
I replaced the last commit, now the tests should pass. |
tbekolay
force-pushed
the
negative-indices
branch
from
221e0cc
to
41377fc
Compare
tbekolay
approved these changes
Mar 2, 2018
This commit adds a comment explaining why a ValueError can occur in an indexing operation and catches the same error in the second indexing operation for consistency.
tbekolay
force-pushed
the
negative-indices
branch
from
d420812
to
e582a19
Compare
These might reference the same elements as positive indices and therefore need special handling. `test_list_indexing` was modified to test negative indices, and to create all plots before the first assertion so that they can be viewed if an assertion fails. Additionally, some test tolerances were raised to accommodate more seeds.
tbekolay
force-pushed
the
negative-indices
branch
from
e582a19
to
c107a47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context:
There is one special case with sliced indexing that still does not correctly work: If a list of indices references the same index twice, but once with a positive integer and once with a negative integer, one of those will overwrite the other one when the slicing is done on an input. This PR fixes that by converting all indices to positive indices (as a canonical representation) before checking for repeated indices.
Interactions with other PRs:
none
How has this been tested?
added a test
How long should this take to review?
Where should a reviewer start?
I'd recommend going commit by commit, but the PR is small enough that looking at the full diff should work too.
Types of changes:
Checklist: