Added function list support for EA.add_output #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed some PEP8 errors, but the rest looks good to me. |
hunse
force-pushed
the
ensarrayfunctionlist
branch
from
7536572
to
4ab84f7
Compare
|
I reduced some of the code duplication between the |
|
LGTM too. I made a few changes to the test (just cosmetic), wrote a changelog entry, and squashed the PEP8 fix (will keep @hunse's commit though); merging! |
Allows a list of functions to be passed in to the EnsembleArray add_output function, so that different functions can be calculated off of the different ensembles. Also added a test. Addresses #562. Thanks to Sean Aubin for fixing some PEP8 errors!
To reduce code duplication
tbekolay
force-pushed
the
ensarrayfunctionlist
branch
from
e7f86d9
to
b48c68b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows a list of functions to be passed in to the ensemble_array
add_output function, so that different functions can be calculated
off of the different ensembles.
Also added a test.
Addresses #562.